MWPW-157776 Prompt Card Block #805
Conversation
TsayAdobe
requested review from
joaquinrivero,
Blainegunn,
saragajic11 and
st-angelo-adobe
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #805 +/- ##
==========================================
+ Coverage 66.94% 67.71% +0.76%
==========================================
Files 47 48 +1
Lines 7431 7604 +173
==========================================
+ Hits 4975 5149 +174
+ Misses 2456 2455 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TsayAdobe
force-pushed
the
promptcard
branch
from
5693cad
to
8ee1b20
Compare
TsayAdobe
force-pushed
the
promptcard
branch
from
ece3d0c
to
74a5eae
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import { readFile } from '@web/test-runner-commands'; | ||
| import { expect } from '@esm-bundle/chai'; | ||
| import sinon from 'sinon'; | ||
| import { waitForElement, delay } from '../../helpers/waitfor.js'; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'waitForElement' is defined but never used.
| document.body.innerHTML = await readFile({ path: './mocks/body-json-more-less.html' }); | ||
| await import('../../../acrobat/scripts/scripts.js'); | ||
| await delay(500); | ||
| await new Promise((resolve) => requestAnimationFrame(resolve)); |
There was a problem hiding this comment.
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
| import { readFile } from '@web/test-runner-commands'; | ||
| import { expect } from '@esm-bundle/chai'; | ||
| import sinon from 'sinon'; | ||
| import { waitForElement, delay } from '../../helpers/waitfor.js'; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'waitForElement' is defined but never used.
| document.body.innerHTML = await readFile({ path: './mocks/body-json-more.html' }); | ||
| await import('../../../acrobat/scripts/scripts.js'); | ||
| await delay(500); | ||
| await new Promise((resolve) => requestAnimationFrame(resolve)); |
There was a problem hiding this comment.
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
|
@overmyheadandbody 🙏 Thank you for your valuable suggestions! I have updated the code. |
templateblock is for a group of prompt cards that have some common settings. The common settings can be in a template.template, groupblock is for a group of prompt cards that have some common settings. It can be authored in a more compact fashion.Resolves: MWPW-157776
Test URLs:
https://promptcard--dc--adobecom.hlx.live/drafts/tsay/prompt-cards?martech=off
https://promptcard--dc--adobecom.hlx.live/drafts/tsay/prompt-cards-template?martech=off
https://promptcard--dc--adobecom.hlx.live/drafts/tsay/prompt-cards-template-group?martech=off
Please go to the Word docs to see the authoring experience.